Use 3 nodes for clustered all tests #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsegismont @vietj Could you guys have a quick look at this? |
tsegismont
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ClusteredSharedCounterTestuses only 2 nodes. When testing with Hazelcast CP subsystem, we need 3 nodes, using 3 nodes makes it easier for us to re-use the test.I have also unified the common parts in the clustered tests. There is some code duplication, but we can't simply create a common parent to move the code there, because they already extend other classes. Maybe a junit rule would make sense here. Let me know if you want to do something with the duplication, it was already there before this PR.