Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TCK instructions #398

Open
arthurdm opened this issue Jan 6, 2020 · 3 comments
Open

Updating TCK instructions #398

arthurdm opened this issue Jan 6, 2020 · 3 comments

Comments

@arthurdm
Copy link
Member

arthurdm commented Jan 6, 2020

We have this page outlining how to run the TCK, but that's quite old now. I am wondering if anyone is using different instructions, etc. If so, we should update that page.

Also - if there's anything specific to running it against SmallRye (CC @EricWittmann @MikeEdgar), we could have a new section on that page for it - which could serve as a sample for other implementations that want to add specific instructions there too.

@EricWittmann
Copy link
Contributor

The SmallRye OpenAPI library isn't a full MP implementation (obviously) so we don't technically run against the TCK in an "official" way. Instead, I have created a custom junit layer that executes all of the TCK tests without spinning up a real environment. It's very useful but does not constitute a real execution of the TCK. That happens in places like Quarkus and Thorntail(rip).

I'm not against documenting what's in SmallRye OpenAPI in some way, but am not convinced it would be appropriate to do that in MP. Also, the documentation would be: mvn test :)

@arthurdm
Copy link
Member Author

arthurdm commented Jan 9, 2020

Fair point. =) Are the instructions still applicable for something like Quarkus?

@EricWittmann
Copy link
Contributor

Honestly I'm not sure - @kenfinnigan is there someone on the Quarkus side who can easily answer this? :)

Azquelt pushed a commit to Azquelt/microprofile-open-api that referenced this issue Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants