Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify build identifier of project inspectors #1213

Open
andre15silva opened this issue Apr 13, 2021 · 1 comment
Open

unify build identifier of project inspectors #1213

andre15silva opened this issue Apr 13, 2021 · 1 comment

Comments

@andre15silva
Copy link
Contributor

Currently we have several identifiers in a project inspector (and its subclasses), due to their different natures (Jenkins, Travis, Github, etc).

It would be introduce a uniform access method to an identifier string such as projectInspector.getIdentifier() that would be overwritten in the subclasses.
@andre15silva
Copy link
Contributor Author

This would allow getting rid of instanceof in the patch classification function introduced in #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andre15silva