Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fixes #161

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Feature/fixes #161

merged 3 commits into from
Nov 13, 2023

Conversation

pmaciel
Copy link
Member

@pmaciel pmaciel commented Nov 13, 2023

Fix compilation warning on handling interpolation matrices (MatrixCache is not fully implemeting the "rule of 5" so I've removed the triggering constructor, the others are sufficient)

Fix a logic error in the generic redistribution method, on detecting indices uniqueness.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5ea733a) 79.40% compared to head (99d7ca0) 79.63%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
+ Coverage    79.40%   79.63%   +0.22%     
===========================================
  Files          822      847      +25     
  Lines        62223    62714     +491     
===========================================
+ Hits         49410    49942     +532     
+ Misses       12813    12772      -41     
Files Coverage Δ
src/atlas/interpolation/Cache.h 100.00% <ø> (ø)
src/atlas/mesh/MeshBuilder.cc 91.08% <100.00%> (+1.37%) ⬆️
src/atlas/mesh/MeshBuilder.h 100.00% <100.00%> (ø)
...atlas/redistribution/detail/RedistributeGeneric.cc 91.00% <100.00%> (ø)
...s/redistribution/detail/RedistributionInterface.cc 100.00% <100.00%> (ø)
src/atlas_f/atlas_module.F90 36.11% <ø> (ø)
...tests/mesh/fctest_mesh_triangular_mesh_builder.F90 100.00% <100.00%> (ø)
...rc/tests/mesh/test_mesh_triangular_mesh_builder.cc 100.00% <100.00%> (ø)
src/tests/redistribution/fctest_redistribution.F90 100.00% <100.00%> (ø)
...s_f/redistribution/atlas_Redistribution_module.F90 96.42% <96.42%> (ø)
... and 2 more

... and 168 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering bugs and fixing warnings!

@wdeconinck wdeconinck merged commit 4c27375 into develop Nov 13, 2023
69 of 71 checks passed
@wdeconinck wdeconinck deleted the feature/fixes branch November 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants