You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted by Titus in an issue, Minhash sketches should be stable and cross-compatible between programs. It makes sense to fall into line with this convention. To this end, rkmh should output either Mash's capnproto schema or a text file akin to sourmash's YAML sigs.
The text was updated successfully, but these errors were encountered:
Commit b9224 partially solves this, but there are still a few items left:
JSON output is ordered alphabetically, which may or may not be okay.
There is no way (at least from the CLI) to change hash seeds, hash functions, alphabet, whether to use non-canonical bases, or the number of hash bits.
Reads/Refs are spat out individually at the moment, which is different than Mash/Sourmash, which collate sets of reads/refs into sketches. I guess there should be a switch for this a la mash -i?
There is no error handling in rkmh hash yet, and there're probably still some performance issues. I have no idea if the structures json.hpp provides are thread-safe, nor have I tested with multiple threads.
There's no way to read the sketches back in, so they're essentially useless at the moment (outside of for debugging purposes).
As noted by Titus in an issue, Minhash sketches should be stable and cross-compatible between programs. It makes sense to fall into line with this convention. To this end, rkmh should output either Mash's capnproto schema or a text file akin to sourmash's YAML sigs.
The text was updated successfully, but these errors were encountered: