Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for recurring payments #85

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: add support for recurring payments #85

wants to merge 11 commits into from

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Aug 29, 2023 •
edited
Loading

No description provided.

@tmigone
feat: add support for recurring payments
b9273fe 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone marked this pull request as draft August 29, 2023 21:07
tmigone added 3 commits August 29, 2023 21:10
@tmigone
fix: add onlyRecurringPayments modifier
b955533 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: dont clamp start date in internal method, be explicit about it
362b29d 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: tests
ab4a467 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone marked this pull request as ready for review August 31, 2023 20:44
@tmigone tmigone marked this pull request as draft August 31, 2023 20:44
@tmigone
feat(rp): add tests
28eec51 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: clarify addTo behavior
cbdf479 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone marked this pull request as ready for review September 4, 2023 19:41
Theodus
Theodus approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/test/contract.test.ts Outdated Show resolved Hide resolved
contracts/test/contract.test.ts Outdated Show resolved Hide resolved
contracts/test/contract.test.ts Outdated Show resolved Hide resolved
contracts/test/contract.test.ts Outdated Show resolved Hide resolved
tmigone and others added 5 commits September 8, 2023 11:25
@tmigone @Theodus
Update contracts/test/contract.test.ts
89f83ba 
Co-authored-by: Theo Butler <theodusbutler@gmail.com>
@tmigone @Theodus
Update contracts/test/contract.test.ts
d65598b 
Co-authored-by: Theo Butler <theodusbutler@gmail.com>
@tmigone
chore: fix typos
27776ab 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: when extending make sure user does not pay for time in the past …
435c700 
…(0xM H-01) (#86)

* fix: when extending make sure user does not pay for time in the past (0xM H-01)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

* fix: revert when extending if amount is not multiple of rate (0xM L-02) (#87)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: deployment files for new contract (#90)
00870dd 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theodus Theodus Theodus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmigone @Theodus