-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref/docs #450
Conversation
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level review:
- Rearrangements of Getting started and Deployment LGTM
- Keys and crypto
- Some remarks on the details, see below
- Structure and scope makes sense to me
- Graphics are helpful. No ideas for improvements here.
Link checks fail due to the updated sections not being in the currently published version of the docs. |
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com> Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>
Co-authored-by: Daniel Weiße <66256922+daniel-weisse@users.noreply.github.com>
Here is the preview: https://deploy-preview-86--edgeless-docs.netlify.app/marblerun/next/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Applied your suggestions please take another look @thomasten @flxflx |
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Proposed changes
Additional info