You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
appears to be causing some funky formatting because it isn't including all the correct attributes on inline elements that get broken up by the <ins>/<del> that the diff inserts.
In this example, the original content is a <p> with all its text wrapped in a nested set of <span> elements with inline style attributes. However, in the diff, <ins> elements break up those spans, and only the first set retain the attributes:
I think we just need to take care to preserve the attributes in two spots, but this definitely needs more investigation:
This diff: https://monitoring.envirodatagov.org/page/671a2a65-b716-4603-8d84-0f88eac21f59/d180ac05-0957-472b-ba8e-66a8e46ca3e9..1e0e4c85-c70b-4e6a-ad3e-3c6ee48e4d6d
appears to be causing some funky formatting because it isn't including all the correct attributes on inline elements that get broken up by the
<ins>
/<del>
that the diff inserts.In this example, the original content is a
<p>
with all its text wrapped in a nested set of<span>
elements with inlinestyle
attributes. However, in the diff,<ins>
elements break up those spans, and only the first set retain the attributes:I think we just need to take care to preserve the attributes in two spots, but this definitely needs more investigation:
web-monitoring-diff/web_monitoring_diff/html_render_diff.py
Lines 1348 to 1350 in 07b5d1e
and:
web-monitoring-diff/web_monitoring_diff/html_render_diff.py
Lines 1626 to 1628 in 07b5d1e
The text was updated successfully, but these errors were encountered: