Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that spelling_language strings must be exactly two or five characters #48

Closed
cxw42 opened this issue Apr 10, 2024 · 2 comments · Fixed by #54
Closed

Clarify that spelling_language strings must be exactly two or five characters #48

cxw42 opened this issue Apr 10, 2024 · 2 comments · Fixed by #54
Labels
clarification Improve text without changing its meaning

Comments

@cxw42
Copy link
Member

cxw42 commented Apr 10, 2024

Per #41,

The format [of a spelling_language value] is ss or ss-TT.

I intended ss to stand for exactly two characters and TT to stand for exactly two characters. However, as @gustaphe commented in editorconfig/editorconfig-vim#210 (comment) , TT could be read as a variable standing for any ISO 3166 code.

Update the specification to clarify that ss represents exactly two characters and TT represents exactly the two characters of an ISO 3166-1 alpha-2 code. Therefore, a spelling_lanugage string as a whole must be exactly two chars (ss) or exactly five chars (ss-TT).

@cxw42 cxw42 added the clarification Improve text without changing its meaning label Apr 10, 2024
@ffes
Copy link
Member

ffes commented Apr 10, 2024

It is always a good thing to clarify things if they turn out to be unclear!

Just a question. I guess the T in TT stands for territory, but what does the s in ss stand for?

@cxw42
Copy link
Member Author

cxw42 commented Apr 21, 2024

You know, I can't remember why I picked that! 😆 I would guess either (1)"s" for spelling, or (2)the letter before "t".

cxw42 added a commit to cxw42/editorconfig-specification that referenced this issue Sep 15, 2024
We do not support the ISO numeric or three-letter codes.

Fixes editorconfig#48
@xuhdev xuhdev closed this as completed in 47c7bea Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Improve text without changing its meaning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants