Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly identical individuals whose difference would make IDMPO inconsistent #560

Open
mereolog opened this issue Mar 22, 2024 · 4 comments
Assignees
Labels
bug Something isn't working examples

Comments

@mereolog
Copy link
Contributor

The table below shows all individuals (from ec8ee5e) such that:

  1. they are not declared as identical (owl:sameAs) or different (owl:differentFrom)
  2. if they were declared different, this would make the IDMP ontology inconsistent because of the functional properties in which these individuals are involved in.

image
possible_identity_gaps 202403220934.xlsx

I think that at least some of them look as different individuals.

(The triples which would make the ontology inconsistent are shown here:
possible_identity_gaps full_search 202403220934.xlsx)

@mereolog mereolog added bug Something isn't working examples labels Mar 22, 2024
@mereolog mereolog added this to the Release 1.1.0 milestone Mar 22, 2024
@ElisaKendall
Copy link
Contributor

@mereolog - I would have to dig in to the details to see what's going on here. If @tw-osthus has time to look into this, that would be helpful. I won't be able to spend the time to debug until after 4/1.

@tw-osthus
Copy link
Contributor

https://precision.fda.gov/uniisearch/srs/unii/136P0076YA
is same substance as https://gsrs.ncats.nih.gov/api/v1/substances/136P0076YA

and the like are correct.

https://precision.fda.gov/uniisearch/srs/unii/${UNII_ID} == https://gsrs.ncats.nih.gov/api/v1/substances/${UNII_ID}

GSRS is using the UNII identifier as part of their IRI. The official UNII URI is the first one.

https://spec.pistoiaalliance.org/idmp/ontology/EXT/Examples/TerlipressinExample/TerlipressinAcetate
should be replaced with the GSRS URI

all the others are most likely wrong and must be fixed

@mereolog mereolog removed this from the Release 1.1.0 milestone Apr 4, 2024
@mereolog
Copy link
Contributor Author

As for:

all the others are most likely wrong and must be fixed

What do you mean that they are wrong?

@mereolog
Copy link
Contributor Author

@tw-osthus , @ElisaKendall would it make sense to fully execute the comment below, i.e., to add all implicit sameAs triples?

https://precision.fda.gov/uniisearch/srs/unii/136P0076YA
is same substance as https://gsrs.ncats.nih.gov/api/v1/substances/136P0076YA

and the like are correct.

https://precision.fda.gov/uniisearch/srs/unii/${UNII_ID} == https://gsrs.ncats.nih.gov/api/v1/substances/${UNII_ID}

@mereolog mereolog added this to the Release 1.2.0 milestone Apr 12, 2024
@mereolog mereolog removed this from the Release 1.2.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples
Projects
None yet
Development

No branches or pull requests

3 participants