Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About update numpy to 2.0 #129

Open
albertandking opened this issue Jun 26, 2024 · 4 comments
Open

About update numpy to 2.0 #129

albertandking opened this issue Jun 26, 2024 · 4 comments

Comments

@albertandking
Copy link
Contributor

Hi, Ed

  1. numpy had released 2.0 at 20240617, ref: https://numpy.org/news/;
  2. pybroker should consider update numpy 1.x to numpy 2.0
  3. I have test numpy 2.0 in pybroker, we can just replace np.float_ to np.float64 in all source code;
  4. then should set numba version great than 0.60.0, ref: https://numba.readthedocs.io/en/stable/release/0.60.0-notes.html
  5. If you consider update it, I will pr to dev branch.
@edtechre
Copy link
Owner

Thank you @albertandking! Yes, please PR. Note, I have already replaced np.float_ references.

@albertandking
Copy link
Contributor Author

Thank you @albertandking! Yes, please PR. Note, I have already replaced np.float_ references.

Ok, I have #130

@edtechre edtechre reopened this Jul 4, 2024
@edtechre
Copy link
Owner

edtechre commented Jul 4, 2024

TA-Lib and Riskfolio-Lib do not yet support Numpy 2.0. Rolling back this change since these libraries are referenced in notebooks.

There will be nothing to stop people from forcing an update to Numpy 2.0 on their own though. Once the ecosystem is more compatible, I will bump the version to Numpy 2.0 again.

@albertandking
Copy link
Contributor Author

TA-Lib and Riskfolio-Lib do not yet support Numpy 2.0. Rolling back this change since these libraries are referenced in notebooks.

There will be nothing to stop people from forcing an update to Numpy 2.0 on their own though. Once the ecosystem is more compatible, I will bump the version to Numpy 2.0 again.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants