Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tooltips for icons so they actually describe what they do #22

Open
luzpaz opened this issue Jul 8, 2021 · 7 comments
Open

Improve tooltips for icons so they actually describe what they do #22

luzpaz opened this issue Jul 8, 2021 · 7 comments

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Jul 8, 2021

Right now, many of the icons are just placeholder names of the icon name, for example: https://github.com/edwardvmills/Silk/blob/master/ControlGrid66.py#L57

@edwardvmills
Copy link
Owner

ok, that's a good one. i'll put it at the top of my todo list

@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 10, 2021

I'll be happy to help. Also If I may, would you consider also formatting the code block in a more readable way? i.e.

def GetResources(self):
		return {'Pixmap' :  path_Silk_icons + '/ControlGrid66.svg', 
                        'MenuText': 'Insert text description', 
                        'ToolTip': 'Insert tooltip description'}

This way when it comes time to translate this workbench, it will be easier to do.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 10, 2022

Maybe you have time to do this?

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 16, 2022

@edwardvmills softest of bumps

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 16, 2023

@wandrewkeech thanks for all your work on #28
While working on #32 I noticed that there are some tooltips that didn't get addressed for example:

return {'Pixmap' : path_Silk_icons + '/ControlGrid3Star66_3Sub.svg', 'MenuText': 'ControlGrid3Star66_3Sub', 'ToolTip': 'ControlGrid3Star66_3Sub'}

Any specific reason why ?

@edwardvmills
Copy link
Owner

i think that command/object was an early prototype, completely subsumed by ControlGridNStar66 (which covers the case where N=3)

maybe it could be deleted, but i probably left it there in case i wanted to pick things out of it.

@edwardvmills
Copy link
Owner

edwardvmills commented Apr 23, 2023

I just pushed a new system for tooltip + popup window for additional info by function. system is in place, 8/25 functions complete. hoping to complete this phase in one more week?

b7a4bf1

it is very challenging to say what the tools do :( as a lot of background info is required, as well as building up to the next tool in sequence.

right now i'm just putting extra info in the simplest Qt message window. long term i want to incorporate images and have the window scrollable. I also want the window to be dockable so it can be placed split screen with FreeCAD. Seems like i should be using Markup, not strings....

this was my very first Qt, so i want to take it slow. It's a step toward having all relevant info included in the workbench.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants