fix: Remove existing Tagular cookie with outdated domain metadata #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/EDX-1729/rv-eventing-cookie-reset
branch
from
11c7fae to
56ab83b
Compare
majidfn
approved these changes
Nov 18, 2024
grmartin
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RV work to fix an unexpected side effect with the
tglr_correlation_idcookie.Previously, the correlation ID cookie work did not set a cookie with the domain, so the browser automatically sets the cookie with the current domain. We introduced the change to specify the domain to
.edx.orghere #32But there are users who have the cookie set with the wrong metadata for the domain (aka the current domain
payment.edx.org).We want to remove these and set a new
tglr_correlation_idcookie with the correct domain metadata.