Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register definition TRM unclear #546

Open
marwaneltoukhy opened this issue Jun 23, 2024 · 0 comments
Open

Register definition TRM unclear #546

marwaneltoukhy opened this issue Jun 23, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@marwaneltoukhy
Copy link
Member

marwaneltoukhy commented Jun 23, 2024

There are some unclear register definitions in https://github.com/efabless/caravel/blob/main/docs/caravel_datasheet_2_register_TRM_r2.pdf

  1. mgmt GPIO registers have 32 bits, shouldn't it only be 1 bit?
  2. reg_mprj_io_xx definitions has some ambiguous bits
    • bit 2 | hold state value | Value of GPIO when in low-power state. @RTimothyEdwards mentioned that this should be removed
    • bit 5,6,7 | analog enable/select/polarity @RTimothyEdwards mentioned they should be removed as they're probably not functioning correctly because we do not have the vswitch enable bit set on the pads
  3. IRQ has 32 bit registers, shouldn't they be 1 bit? Registers also need to have better documentation
@marwaneltoukhy marwaneltoukhy added the documentation Improvements or additions to documentation label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants