Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): PR is reported as ✅ even if some checks are not run #416

Open
davinkevin opened this issue Jul 22, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@davinkevin
Copy link

Hello 👋

I would like to report something I think is a bug.

If I check a random PR I've just created, I have the following result, with ✅ in the first column

image

However, in the GitHub UI, I have this

Some checks haven’t completed yet
1 skipped, 7 successful, 1 expected, and 1 neutral checks

image

I would expect the report to contain the current state, especially because I have one manual check that is required to merge… and in this case, it's not run even if ✅ is reported by spr.

Thank you!

@chriscz chriscz added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants