Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legend] Align bottom of legend to the zero axis #2442

Open
mbondyra opened this issue May 28, 2024 · 1 comment
Open

[Legend] Align bottom of legend to the zero axis #2442

mbondyra opened this issue May 28, 2024 · 1 comment

Comments

@mbondyra
Copy link
Contributor

mbondyra commented May 28, 2024

The legend and legend table that is longer than the chart looks a bit weird going below the chart. We instead want to align it to zero axis.

Zight 2024-06-03 at 10 53 14 AM

Originally posted by @gvnmagni in #2426 (comment)

@nickofthyme
Copy link
Collaborator

nickofthyme commented Jun 3, 2024

Personally, I think this is a very low priority/impact.

Even if we did do this I'm sure it would be split between people liking it and others asking why the legend height is being truncated. Then you have to question what the top condition is like to match the bottom.

Besides the axis/legend sizing logic being very complex as it is.

We could revisit this idea when/if we move towards composable legends that are entirely separate from the chart and can be common across many charts, as mentioned in #682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants