Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we upgrade the eslint related plugins? #29

Open
chen201724 opened this issue Nov 16, 2023 · 1 comment
Open

Should we upgrade the eslint related plugins? #29

chen201724 opened this issue Nov 16, 2023 · 1 comment

Comments

@chen201724
Copy link

I noticed that in the recent upgrade, eslint was upgraded to version 7 separately, causing a conflict between the current version of eslint and the peerDependencies of eslint-plugin-mocha (eslint-plugin-mocha requires eslint@"^2.0.0 || ^3.0.0 || ^4.0.0").

The problem is that npm install will fail normally unless the --force or --legacy-peer-deps flag is enabled.

Should we upgrade the eslint related dependencies (such as eslint-plugin-mocha), or should we roll back eslint to its original version?

I am happy to resolve this issue once the solution is confirmed :)

@chen201724
Copy link
Author

"eslint-plugin-mocha" dependence seems to have no references anymore, or can it be deleted directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant