The ELECTRON_BUILDER_BINARIES_MIRROR variable doesn't effect winCodeSign

[huxiaoxi1992]

• Version: 21.2.0

• Target: win x64 nsis

• Environment: gitlab-ce CI/CD -> image: electronuserland/builder:wine-mono

The electron-builder-binaries download slowly, I have hosted my own binaries mirror and added some environment variables due to #3761.

winCodeSign seems to be not effected by this variable.

Sometimes, it runs successful with the default url, is it possible to make winCodeSign download from the mirror variable?

[OutgoingOpossum]

I can confirm this does not work with electron-builder@20.44.4 for target platform=win32 arch=x64 electron=2.0.14

I think this because the windows code sign routine uses getBin() directly

electron-builder/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts

Lines 14 to 16 in f0bf67c

	export function getSignVendorPath() {
	return getBin("winCodeSign")
	}

while other processes use getBinFromUrl()

electron-builder/packages/app-builder-lib/src/targets/MsiTarget.ts

Line 74 in f0bf67c

const vendorPath = await getBinFromUrl("wix", "4.0.0.5512.2", "/X5poahdCc3199Vt6AP7gluTlT1nxi9cbbHhZhCMEu+ngyP1LiBMn+oZX7QAZVaKeBMc2SjVp7fJqNLqsUnPNQ==")

electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts

Line 34 in f0bf67c

const nsisResourcePathPromise = new Lazy(() => getBinFromUrl("nsis-resources", "3.4.1", "Dqd6g+2buwwvoG1Vyf6BHR1b+25QMmPcwZx40atOT57gH27rkjOei1L0JTldxZu4NFoEmW4kJgZ3DlSWVON3+Q=="))

electron-builder/packages/app-builder-lib/src/targets/nsis/nsisUtil.ts

Line 20 in f0bf67c

return getBinFromUrl("nsis", "3.0.4", "MNETIF8tex6+oiA0mgBi3/XKNH+jog4IBUp/F+Or7zUEhIP+c7cRjb9qGuBIofAXQ51z3RpyCfII4aPadsZB5Q==")

which seems to be a wrapper around getBin() adding support for the configuration variables in question

electron-builder/packages/app-builder-lib/src/binDownload.ts

Lines 13 to 36 in f0bf67c

	export function getBinFromUrl(name: string, version: string, checksum: string): Promise<string> {
	const dirName = `${name}-${version}`
	let url: string
	if (process.env.ELECTRON_BUILDER_BINARIES_DOWNLOAD_OVERRIDE_URL) {
	url = process.env.ELECTRON_BUILDER_BINARIES_DOWNLOAD_OVERRIDE_URL + "/" + dirName + ".7z"
	}
	else {
	const baseUrl = process.env.NPM_CONFIG_ELECTRON_BUILDER_BINARIES_MIRROR ||
	process.env.npm_config_electron_builder_binaries_mirror ||
	process.env.npm_package_config_electron_builder_binaries_mirror ||
	process.env.ELECTRON_BUILDER_BINARIES_MIRROR ||
	"https://github.com/electron-userland/electron-builder-binaries/releases/download/"
	const middleUrl = process.env.NPM_CONFIG_ELECTRON_BUILDER_BINARIES_CUSTOM_DIR ||
	process.env.npm_config_electron_builder_binaries_custom_dir ||
	process.env.npm_package_config_electron_builder_binaries_custom_dir ||
	process.env.ELECTRON_BUILDER_BINARIES_CUSTOM_DIR ||
	dirName
	const urlSuffix = dirName + ".7z"
	url = `${baseUrl}${middleUrl}/${urlSuffix}`
	}
	return getBin(dirName, url, checksum)
	}

This might also affect #3954

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[ghost]

FWIW this is also occuring for me using "electron-builder": "^21.2.0"

I can work around the problem by by pointing ELECTRON_BUILDER_CACHE to a manually downloaded copy of winCodeSign, but having winCodeSign download same as e.g. nsis would be better.

[hausenism]

^22.0.0 fix this.