Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a TypeScript definition #48

Open
mahnunchik opened this issue Jun 11, 2020 · 6 comments
Open

Add a TypeScript definition #48

mahnunchik opened this issue Jun 11, 2020 · 6 comments
Labels
enhancement help wanted

Comments

@mahnunchik
Copy link

It wold be nice to add a TypeScript definition.

Related: electron/forge#1755
@malept
Copy link
Member

malept commented Jun 11, 2020

See electron-userland/electron-installer-snap#72 for an example of how to do it.

@ffflorian
Copy link
Contributor

I created a PR on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#54338

@malept
Copy link
Member

malept commented Jul 7, 2021

I would actually prefer an in-package definition type rather than a separate one.

@ffflorian
Copy link
Contributor

What do you think about rewriting this in TypeScript? It's not that much work.

@ffflorian ffflorian mentioned this issue Jul 8, 2021
Closed
@ffflorian
Copy link
Contributor

ffflorian commented Jul 8, 2021 •
edited
Loading

I opened a PR for the definitions @malept :)

@malept
Copy link
Member

malept commented Jul 27, 2021

What do you think about rewriting this in TypeScript? It's not that much work.

I would be hesitant to convert this to TypeScript mostly because I need to see how comprehensive the testsuite is first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add TypeScript definitions
3 participants
@malept @mahnunchik @ffflorian