Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions >2.0.0 no longer work in Electron 4 #145

Open
Nantris opened this issue May 11, 2019 · 2 comments
Open

Versions >2.0.0 no longer work in Electron 4 #145

Nantris opened this issue May 11, 2019 · 2 comments

Comments

@Nantris
Copy link

Nantris commented May 11, 2019

Upgrading causes the spellchecker to fail silently and not highlight any misspelling. I tried removing all my node_modules and reinstalling, but no luck.

@ouassimBenMosbah
Copy link

I can confirm. It is working fine with electron 4.2.2 and electron-spellchecker 1.1.2 while it isn't with electron 4.2.2 and electron-spellchecker 2.0.0

@Nantris
Copy link
Author

Nantris commented May 27, 2019

@ouassimBenMosbah 2.0.0 works for me on Electron@4.1.x, but anything above that does not. The spellcheck library it imports/requires changes in one of the versions after 2.0.0 which I suspected was the source of my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants