-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depends on archaic rcinfo
node module
#179
Comments
I'd make a PR over on rcinfo, but that project hasn't been touched in 9 years and the ShowVer.exe binary it ships with is 22 years old at this point. Also, this issue only affects folks who have been successfully vending MSIs for a product and are now updating their runners in a way that causes I think the silent fail happens because electron-wix-msi/src/utils/rc-edit.ts Line 54 in dc4db70
This is what I mean by the incorrect assumption for the fallback: electron-wix-msi/src/utils/rc-edit.ts Line 117 in dc4db70
For an electron app, the |
As described, this project depends on rcinfo to extract the main executable's
VERSIONINFO
to then apply to the stub executable viarcedit
.Unfortunately if the host machine doesn't have the (unsupported since 2020) "Visual Studio 2010 (VC++ 10.0) SP1" redistributables installed (for x86!!! x64 doesn't fix this, watch out), the VERSIONINFO will silently fall back to the Electron app's package metadata.
This is a good fallback but it unfortunately makes an incorrect assumption about what "File Version" should be. electron-packager uses the
buildVersion
packagerConfig property for the "File Version" of the vended executable, while electron-wix-msi falls back to theappVersion
(aka "Product Version" in Windows).The text was updated successfully, but these errors were encountered: