Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependencies #337

Open
crystalfp opened this issue Oct 25, 2024 · 1 comment
Open

Deprecated dependencies #337

crystalfp opened this issue Oct 25, 2024 · 1 comment
Labels
breaking change dependencies Pull requests that update a dependency file

Comments

@crystalfp
Copy link

Installing the latest version of the package gives two deprecation notices:

PS> npm -g install @electron/asar@3.2.14
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

changed 13 packages in 846ms

Could you look at them? I think the 2nd one is straightforward to fix.
Thanks!

@erikian
Copy link
Member

erikian commented Nov 1, 2024

Hey @crystalfp! We plan to bump glob and other dependencies once we're able to upgrade the minimum Node.js version and release the next major version of @electron/asar, see #332 (comment) for details. This is a valid issue so I'll keep it open until we get around to it, just wanted to let you know about the current status.

@erikian erikian added dependencies Pull requests that update a dependency file breaking change labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants