Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support codesigning dmg images for macOS ^10.11.5 #127

Closed
sethlu opened this issue Mar 2, 2017 · 3 comments
Closed

Support codesigning dmg images for macOS ^10.11.5 #127

sethlu opened this issue Mar 2, 2017 · 3 comments

Comments

@sethlu
Copy link
Contributor

sethlu commented Mar 2, 2017

Address that the identity of dmg file when downloaded from a web server cannot be confirmed. codesign of macOS ^10.11.5 may sign dmg images and electron-osx-sign may provide a similar procedure for signing those files to that for signing app bundles.

Ref: #64 (comment)
Technical note: https://developer.apple.com/library/prerelease/content/technotes/tn2206/_index.html

@sethlu sethlu added this to the Future Release milestone Mar 12, 2017
@develar
Copy link
Contributor

develar commented Aug 25, 2017

electron-builder 19.26.0 is able to sign DMG. Nothing to contribute to this module — is it simple one-line command (part of DMG creation).

@sethlu
Copy link
Contributor Author

sethlu commented Aug 25, 2017

@develar cool! 😸 The issue dated back is about that generated dmg files need signing the same way as an app bundle, or gatekeeper will complain about unrecognized developer. So this feature request was trying to minimize procedure of setting up the same signing identities and passing them to codesign... Great to hear it's already made available in electron-builder!

@alirezavalizade
Copy link

@develar electron builder is not able to handle the notarize or hardedRuntime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants