Default embedded.provisionprofile doesn't used in signApplication

[mahnunchik]

Hello,

I've faced with different behavior in @electron/osx-sign v 1.0.5 vs electron-osx-sign v 0.5.0.

If options provisioningProfile and preEmbedProvisioningProfile are not specified (preEmbedProvisioningProfile is true by default) then default embedded.provisionprofile is used here

osx-sign/src/util-provisioning-profiles.ts

Lines 108 to 111 in 06b32b5

	export async function preEmbedProvisioningProfile (opts: ValidatedSignOptions, profile: ProvisioningProfile | null) {
	async function embedProvisioningProfile (profile: ProvisioningProfile) {
	debugLog('Looking for existing provisioning profile...');
	const embeddedFilePath = path.join(getAppContentsPath(opts), 'embedded.provisionprofile');

and successfully embedded here

osx-sign/src/util-provisioning-profiles.ts

Line 124 in 06b32b5

await fs.copy(profile.filePath, embeddedFilePath);

after executing https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L381C11-L381C38

But the following sign application action

osx-sign/src/sign.ts

Line 404 in 06b32b5

await signApplication(validatedOpts, identityInUse);

doesn't use it here

osx-sign/src/sign.ts

Lines 226 to 228 in 06b32b5

	provisioningProfile: opts.provisioningProfile
	? await getProvisioningProfile(opts.provisioningProfile, opts.keychain)
	: undefined

because validatedOpts.provisioningProfile is undefined as it is in original options.

[mahnunchik]

electron-osx-sign filled out the options with the correct profile https://github.com/electron/osx-sign/blob/v0.5.0/util-provisioning-profiles.js#L172

[mahnunchik]

The same for identity