Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling universal links causes crash when the user is logged out #7837

Open
denasescu opened this issue Aug 28, 2024 · 0 comments
Open

Handling universal links causes crash when the user is logged out #7837

denasescu opened this issue Aug 28, 2024 · 0 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@denasescu
Copy link

Steps to reproduce

  1. Log out of Element app
  2. Open the app by triggering universal link for user
  3. Navigate back by selecting All chats
  4. Notice that All chats view is empty since it has no data to populate
  5. When you select spaces button from tab bar or search bar, notice the app crashes
Screen.Recording.2024-08-28.at.14.44.54.mov

Outcome

What did you expect?

  • I would expect that /user universal link to be handled in the same way as the /room universal link: when there is no account, the app should display the authentication controller, wait for a a successful login, and then retry the link.

What happened instead?

  • In LegacyAppDelegate, when the /user link is received, the check for activeAccounts is missing, so contact details controller is presented anyway. Therefore, if the user interacts with the UI, the app crashes.

Your phone model

iPhone 15 Plus

Operating system version

17.5

Application version

1.11.17

Homeserver

No response

Will you send logs?

Yes

@denasescu denasescu added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

1 participant