Disable drop onto parent folder #2348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Feb 1, 2024
| @@ -828,7 +828,7 @@ namespace Files.FileUtils { | |||
| var parent = drop_file.get_parent (); | |||
|
|
|||
| if (parent != null && parent.equal (target_location)) { | |||
| valid_actions &= Gdk.DragAction.LINK; // Only LINK is valid | |||
| valid_actions = Gdk.DragAction.DEFAULT; // Ignore (GitHub bug #1759) | |||
There was a problem hiding this comment.
According to docs:
DEFAULT - Means nothing, and should not be used.
Also I'm getting the replace dialog here now for files which seems even less desirable than the symlink behavior
There was a problem hiding this comment.
Not sure what to use for "Do Nothing" then, I guess use 0? I'll just drop this and revisit in Gtk4.
|
Closing - will revisit in Gtk4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759
Simplest possible fix. As DND will have to be completely rewritten for Gtk4 there is no point in doing more.