Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gtk4Prep] BreadcrumbEntry: Use EventControllerKey #2389

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 23, 2024

Behaviours that should be unaffected when the entry is focused are

  • Tab completion (Tab)
  • Change entry to parent path (<Control>Up)
  • Exit edit mode and focus view (<Control>Down)
  • Do not exit if Enter pressed in search mode

Cleanups

  • Merge single-use or one-line functions
  • Do not use event.is_modifier
  • Do not try to handle shortcut already used as action accelerator by Window

@danirabbit danirabbit enabled auto-merge (squash) January 23, 2024 16:46
@danirabbit danirabbit merged commit 54fe65a into main Jan 23, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/gtk4prep-breadcrumbentry-eventkey branch January 23, 2024 16:47
@danirabbit
Copy link
Member

Appreciate the notes for things to test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants