Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractDirectoryView: Use EventControllerScroll #2408

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Feb 2, 2024

Scroll handler functions in AbstractDirectoryView merged.
Workaround needed because Gtk.EventControllerScroll swallows all scroll events in CAPTURE mode even if not handled and does not receive them at all in BUBBLE mode. Therefore it is only active when a modifier is pressed.

@jeremypw jeremypw marked this pull request as draft February 2, 2024 21:05
@jeremypw jeremypw changed the title Use EventControllerScroll; workaround silliness [GtkPrep] View: Use EventControllerScroll Feb 2, 2024
@jeremypw jeremypw changed the title [GtkPrep] View: Use EventControllerScroll AbstractDirectoryView: Use EventControllerScroll Sep 30, 2024
@jeremypw jeremypw marked this pull request as ready for review September 30, 2024 14:52
@jeremypw jeremypw requested a review from a team September 30, 2024 14:52
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here!

@danirabbit danirabbit merged commit 37ead8a into main Oct 8, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/gtk4prep-view-eventscroll branch October 8, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants