Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertiesWindow: handle permpanel failure case in permpanel widget #2469

Merged
merged 5 commits into from
Sep 5, 2024
Merged

PropertiesWindow: handle permpanel failure case in permpanel widget #2469

merged 5 commits into from
Sep 5, 2024

Conversation

danirabbit
Copy link
Member

Review with "hide whitespace changes"

  • Move the failure to get permissions handling into the function that creates the perm grid. Simplifies packing it into the stack and perm_grid can be scoped down to that function
  • Simplify making the grid insenstive. Can't use get_children in gtk4

@danirabbit danirabbit requested a review from a team September 3, 2024 19:16
jeremypw
jeremypw approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to work and makes sense

@danirabbit danirabbit merged commit ed1fb9a into main Sep 5, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/propertieswindow-alwayspermpanel branch September 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw