Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BookmarkRow: delete focused bookmark with delete key #2477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

No description provided.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 8, 2024

These bookmarks only work as expected if the sidebar has keyboard focus, which is not straightforward to achieve at the moment. The sidebar item may be highlighted but pressing "Del" will rename delete a "real" file in the view if the the view in has focus. Starting renaming is not a great problem but unexpected deletion is not ideal even though it may be undoable.

The sidebar can be focused by right-clicking on an item to show the menu (in which case you might as well use the menu options) or repeatedly pressing <Shift>Tab until the correct widget is focused.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 8, 2024

It may be better to hold on this until #2353 is merged? I'll set it open for review as the subject has attention.

@jeremypw
Copy link
Collaborator

@danirabbit What are your thoughts on using modified shortcuts for sidebar actions? e.g. <Alt>Del, <Alt>F2 instead of the same ones as the Directory View?

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it a good idea to have the same accelerator to delete two different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants