From f9abf117ff46c84ad5ed4d2db54e32544f3ba07b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danielle=20For=C3=A9?= Date: Fri, 29 Mar 2024 10:27:07 -0700 Subject: [PATCH 1/2] AppSettingsView: fix row activation --- src/Permissions/Widgets/AppSettingsView.vala | 6 ++++++ src/Permissions/Widgets/PermissionSettingsWidget.vala | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Permissions/Widgets/AppSettingsView.vala b/src/Permissions/Widgets/AppSettingsView.vala index a5762270..5636836e 100644 --- a/src/Permissions/Widgets/AppSettingsView.vala +++ b/src/Permissions/Widgets/AppSettingsView.vala @@ -65,6 +65,12 @@ public class Permissions.Widgets.AppSettingsView : Switchboard.SettingsPage { update_view (); + permission_box.row_activated.connect ((row) => { + if (row is PermissionSettingsWidget) { + row.active = !row.active; + } + }); + reset_button.clicked.connect (() => { if (selected_app != null) { selected_app.reset_settings_to_standard (); diff --git a/src/Permissions/Widgets/PermissionSettingsWidget.vala b/src/Permissions/Widgets/PermissionSettingsWidget.vala index 65cbb458..44acb755 100644 --- a/src/Permissions/Widgets/PermissionSettingsWidget.vala +++ b/src/Permissions/Widgets/PermissionSettingsWidget.vala @@ -67,9 +67,5 @@ public class Permissions.Widgets.PermissionSettingsWidget : Gtk.ListBoxRow { child = grid; bind_property ("active", allow_switch, "active", BIDIRECTIONAL); - - activate.connect (() => { - allow_switch.activate (); - }); } } From f018d68d15f17e1305aa7a892cc5003e34d27d99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danielle=20For=C3=A9?= Date: Fri, 29 Mar 2024 11:07:18 -0700 Subject: [PATCH 2/2] Also fix sandbox box --- src/Permissions/Widgets/AppSettingsView.vala | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Permissions/Widgets/AppSettingsView.vala b/src/Permissions/Widgets/AppSettingsView.vala index 5636836e..7bb0c0c4 100644 --- a/src/Permissions/Widgets/AppSettingsView.vala +++ b/src/Permissions/Widgets/AppSettingsView.vala @@ -71,6 +71,12 @@ public class Permissions.Widgets.AppSettingsView : Switchboard.SettingsPage { } }); + sandbox_box.row_activated.connect ((row) => { + if (row is PermissionSettingsWidget) { + row.active = !row.active; + } + }); + reset_button.clicked.connect (() => { if (selected_app != null) { selected_app.reset_settings_to_standard ();