New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moment locale problem #5

Open

azatTemirbek opened this issue Jul 22, 2020 · 0 comments

azatTemirbek commented Jul 22, 2020

At first render month translations not applied so it displays in English on re render it renders correct month names.
I guess we should move

componentDidMount() {
    moment.updateLocale(this.props.localeLanguage, this.props.localeSettings);
  }

to the constructor or provide moment from props so that user could provide own moment.

gmonte mentioned this issue

fix(locale): moved moment.updateLocale to constructor #6

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment