Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: set spacing on boxes, use header label features #17

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

danirabbit
Copy link
Contributor

Screenshot from 2024-10-17 12 35 49

  • Set spacing on boxes instead of individual widgets
  • Set mnemonic widgets for entries so that are labeled for the screen reader
  • Use secondary_text feature of HeaderLabel for additional description text. This makes sure it's read by the screen reader and that we aren't hiding helpful info
  • Use placeholder feature of entry instead of "such as"

@danirabbit danirabbit requested a review from a team October 17, 2024 19:39
@alainm23
Copy link
Contributor

It looks cleaner, thanks.

@alainm23 alainm23 closed this Oct 17, 2024
@alainm23 alainm23 reopened this Oct 17, 2024
@alainm23 alainm23 enabled auto-merge (squash) October 17, 2024 22:15
@alainm23 alainm23 merged commit 31cad16 into main Oct 17, 2024
3 checks passed
@alainm23 alainm23 deleted the danirabbit/formheaders-boxlayout branch October 17, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants