New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review #2

Open

dmcg89 opened this issue Sep 17, 2019 · 0 comments

dmcg89 commented Sep 17, 2019

Nice use of docstrings
You could improve commenting throughout your code within the functions to describe what is happening more clearly
Good job making your code modular and organizing everything into functions
Clean up the TODOs after you are finished with them, many of your TODOs would make nice comments if you simply delete the “TODO” part
Good job using semantic variable naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment