fix: fix division by zero issue in v0.17.0

elys-network · Nov 28, 2023 · 327fa29 · 327fa29
1 parent 39e3a81
commit 327fa29
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/x/margin/types/calc_funding_rate.go b/x/margin/types/calc_funding_rate.go
@@ -8,10 +8,19 @@ import (
 func CalcFundingRate(longAmount, shortAmount sdk.Int, baseRate, maxRate, minRate sdk.Dec) sdk.Dec {
 	var ratio sdk.Dec
 
+	// Check for division by zero when longAmount > shortAmount
 	if longAmount.GT(shortAmount) {
+		if shortAmount.IsZero() {
+			// Handle the case where shortAmount is zero
+			return maxRate
+		}
 		ratio = sdk.NewDecFromInt(longAmount).Quo(sdk.NewDecFromInt(shortAmount))
 		return sdk.MinDec(sdk.MaxDec(baseRate.Mul(ratio), minRate), maxRate)
 	} else if shortAmount.GT(longAmount) {
+		if longAmount.IsZero() {
+			// Handle the case where longAmount is zero
+			return maxRate
+		}
 		ratio = sdk.NewDecFromInt(shortAmount).Quo(sdk.NewDecFromInt(longAmount))
 		return sdk.MinDec(sdk.MaxDec(baseRate.Mul(ratio).Neg(), minRate), maxRate)
 	} else {