Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk to v3 #186

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Update aws-sdk to v3 #186

merged 2 commits into from
Mar 22, 2024

Conversation

gorner
Copy link
Contributor

@gorner gorner commented Feb 29, 2024

What Changed & Why

I then checked that the existing test suite still passed via npm run test, and npm link-ed the module into an existing Ember app that uses this package to confirm that, at least, that app's deploy would continue to work as expected.

Related issues

PR Checklist

  • Add tests – not relevant to these changes; existing tests all pass
  • Add documentation – not relevant to these changes
  • Prefix documentation-only commits with [DOC] – not applicable

People

Mention people who would be interested in the changeset (if any)
@lukemelia

@gorner
Copy link
Contributor Author

gorner commented Mar 21, 2024

@lukemelia ping – let me know if there's anything else you need here 🙂

@lukemelia
Copy link
Contributor

Looks good. Thanks for tackling this @gorner

@lukemelia lukemelia merged commit fb7016c into ember-cli-deploy:master Mar 22, 2024
8 checks passed
@lukemelia lukemelia added dependencies Pull requests that update a dependency file internal labels Mar 23, 2024
@lukemelia lukemelia mentioned this pull request Mar 23, 2024
1 task
@lukemelia
Copy link
Contributor

Released as 4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS SDK v2 deprecation warning
2 participants