Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
aws-sdk
(v2) package with equivalent v3 packages, due to v2 going into maintenance modeaws-sdk-js-codemod
to update codeendpoint
URL and updatedcredentials
directly into the S3 client's options, which seemed logical based on [Feature]: Transform AWS.Endpoint instance creation with URL aws/aws-sdk-js-codemod#694I then checked that the existing test suite still passed via
npm run test
, andnpm link
-ed the module into an existing Ember app that uses this package to confirm that, at least, that app's deploy would continue to work as expected.Related issues
PR Checklist
People
Mention people who would be interested in the changeset (if any)
@lukemelia