-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI flag for --live-reload-js-url #150
Comments
@chancancode - Would this resolve the issue that you and @NullVoxPopuli were discussing RE: codesandbox the other day? |
@rwjblue we spend some time with |
Bump. Any chance of getting this to the finish line? Thanks! |
@navels It's almost finished actually 😄 @lifeart done an awesome work on this and fixtures (a related problem on the test side). AFAIK it's pending a final review right now: |
The config value
liveReloadJsUrl
can be set via.ember-cli
but not as a command-line flag (--live-reload-js-url
).This is different from the four config values that can be set using either the config file or CLI flags (see photo).
FOR REFERENCE (photo from repo readme: https://github.com/ember-cli/ember-cli-inject-live-reload)
END REFERENCE
Would you be open to making liveReloadJsUrl configurable via a CLI flag? If so, is there any place in addition to the following file that needs to be modified?
https://github.com/ember-cli/ember-cli/blob/073c32eff73c58eee62d6327b50f4422f0cd01cc/lib/commands/serve.js#L62
cc @rwjblue @kellyselden happy to hear your thoughts about this
The text was updated successfully, but these errors were encountered: