-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need option '--decorators=true' thrown when transforming action(function) {})
#229
Comments
i also ran to the same issue, with
which seems result from the same line of logic , |
I just hit the same with:
|
Was there every a resolution to this? It basically negates the usefulness of this codemod for me as I have properties like this on pretty much every route / controller |
I think it would be really helpful to know what Removing that last check just does what I was originally expecting this codemod to do! |
Same issue here, even though the 'no-actions-hash' eslint rule dictates that this is the correct way of wiring up actions, any classic class that uses it gets skipped during the codemod.
https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-actions-hash.md
|
Hmm I have almost 1000 of this style of action decorator in the codebase. Anyone here find a good way of leveraging this code mod for individual who used action decorators in the ember classic style? |
With a pretty vanilla run of this codemod, I saw these errors in the logs:
Each of them (I only checked the first few) seems to be pointing to a function that is defined using the action import. E.g.:
The text was updated successfully, but these errors were encountered: