Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemod deletes code comments #253

Open
boydkr opened this issue Mar 13, 2020 · 1 comment
Open

Codemod deletes code comments #253

boydkr opened this issue Mar 13, 2020 · 1 comment

Comments

@boydkr
Copy link

boydkr commented Mar 13, 2020

I wasn't expecting the codemod to delete many comments in our code. One small example:
before

export default Component.extend({
    //To show or hide sibling checkboxes when one is hovered
    actions: {
        onMouseEnter() {
            this.set('siblingHovered', true);
        },
        onMouseExit() {
            this.set('siblingHovered', false);
        },
    },
});

after

@classic
export default class CategorySelect extends Component {
  @action
  onMouseEnter() {
    this.set('siblingHovered', true);
  }

  @action
  onMouseExit() {
    this.set('siblingHovered', false);
  }
}
@bmaehr
Copy link

bmaehr commented Oct 7, 2024

This is really a major issue.

It is also not possible to workaround untransformable things by commenting them out because they get lost then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants