Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not pass on Windows #5

Open
dustinsoftware opened this issue Jul 15, 2019 · 4 comments
Open

Tests do not pass on Windows #5

dustinsoftware opened this issue Jul 15, 2019 · 4 comments
Labels

Comments

@dustinsoftware
Copy link
Contributor

dustinsoftware commented Jul 15, 2019

Steps to repro:

  1. Clone the repo
  2. Restore packages with yarn
  3. Run yarn test
    image
C:\code\ember-no-implicit-this-codemod>ember version --verbose && npm --version && yarn --version
ember-cli: 3.11.0-beta.3
http_parser: 2.8.0
node: 10.16.0
v8: 6.8.275.32-node.52
uv: 1.28.0
zlib: 1.2.11
brotli: 1.0.7
ares: 1.15.0
modules: 64
nghttp2: 1.34.0
napi: 4
openssl: 1.1.1b
icu: 64.2
unicode: 12.1
cldr: 35.1
tz: 2019a
os: win32 x64
6.9.0
1.15.2
@kellyselden
Copy link

I'm getting this on Windows too

Error: EEXIST: file already exists, mkdir 'C:\Users\kelly\AppData\Local\Temp\kelly\if-you-need-to-delete-this-open-an-issue-sync-disk-cache'
    at Object.mkdirSync (fs.js:764:3)
    at sync (C:\Users\kelly\AppData\Roaming\npm-cache\_npx\4824\node_modules\ember-no-implicit-this-codemod\node_modules\mkdirp\index.js:71:13)

@rwjblue
Copy link
Member

rwjblue commented Aug 22, 2019

@kellyselden - were you also running the tests in this packages test suite or actually running the codemod on your app?

@kellyselden
Copy link

I was trying to get it to work in ember-cli-update, so the code looked something like this.

cp.spawn('npx', ['ember-no-implicit-this-codemod', url, 'app/'], { shell: true });

@NullVoxPopuli
Copy link
Collaborator

is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants