-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop najax
global by default?
#246
Comments
In case it wasn't clear from the bulleted list, I'm strongly in favor of removing 😸 |
👍 Sounds good.
Using fetch sounds like a great idea. I think that both fetch and node-fetch are pretty common tools in SSR and do a good job at providing API consistency. The fact that this all comes bundled up for us with ED + ember-fetch is awesome, so strongly in favor of this. |
Frankly I only vaguely remember the differences between these libraries. IIRC the primary difference I ran into was something related to I think if it truly is as easy as |
For a long time ember-data itself only supported making jQuery requests, and since
👍 awesome, thank you! I'll make sure it is well documented (in the release notes, in the README, and likely in other projects as we update them to |
I think this has served it's purpose. 👍 on dropping. |
As we continue work towards the next major version (will be v3.0.0), I'd like to seriously consider dropping
najax
from the default set of global properties added by this library.The primary reasons are:
ember-fetch
(or globalfetch
) if present, and does not need special logic aroundnajax
ember-fetch
by default, and do not include jQuery by default. Considering thatnajax
is ajQuery.ajax
emulation API, I think this library should avoid exposing it.najax
(as a dependency of this library) is difficult for the host application to control (e.g. get their own version), and would be better if they provided it themselves (viabuildSandboxGlobals
API)najax: require('najax')
viabuildSandboxGlobals
)fetch
usage)Thoughts?
The text was updated successfully, but these errors were encountered: