From 46cbdcf420dee5c01d40bbfe73dd36647c01c54f Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Mon, 29 Apr 2024 13:40:48 -0700 Subject: [PATCH 1/3] Adding Krystan HuffMenne to the Ember Data core team --- data/team-member/krystan-huffmenne.md | 1 + data/team-member/scott-newcomer.md | 2 +- tests/unit/controllers/teams-test.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/data/team-member/krystan-huffmenne.md b/data/team-member/krystan-huffmenne.md index a5998fec..0a339257 100644 --- a/data/team-member/krystan-huffmenne.md +++ b/data/team-member/krystan-huffmenne.md @@ -8,4 +8,5 @@ image: khuffmenne.jpg added: 2023-05-19T00:00:00.000Z teams: - typescript + - data --- diff --git a/data/team-member/scott-newcomer.md b/data/team-member/scott-newcomer.md index 223fa71b..c36b554b 100644 --- a/data/team-member/scott-newcomer.md +++ b/data/team-member/scott-newcomer.md @@ -7,5 +7,5 @@ twitter: 'https://twitter.com/puekey' image: snewcomer.jpg added: 2022-08-14T09:00:00.000Z teams: - - data + - alumni --- diff --git a/tests/unit/controllers/teams-test.js b/tests/unit/controllers/teams-test.js index 5114b704..ea76d9a8 100644 --- a/tests/unit/controllers/teams-test.js +++ b/tests/unit/controllers/teams-test.js @@ -65,7 +65,7 @@ module('Unit | Controller | teams', function (hooks) { // Create an intermediate data structure for assertion const output = dataTeamMembers.map((teamMember) => teamMember.id); - assert.deepEqual(output, ['chris-thoburn', 'scott-newcomer']); + assert.deepEqual(output, ['chris-thoburn', 'krystan-huffMenne']); }); test('We sort Learning team members by when they were first added', function (assert) { From 63e1c6d1bb30dd648f6a18b807461169ae3d2055 Mon Sep 17 00:00:00 2001 From: Ignace Maes Date: Wed, 1 May 2024 08:00:35 +0200 Subject: [PATCH 2/3] Update tests/unit/controllers/teams-test.js Co-authored-by: Krystan HuffMenne --- tests/unit/controllers/teams-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/controllers/teams-test.js b/tests/unit/controllers/teams-test.js index ea76d9a8..5d1906a2 100644 --- a/tests/unit/controllers/teams-test.js +++ b/tests/unit/controllers/teams-test.js @@ -65,7 +65,7 @@ module('Unit | Controller | teams', function (hooks) { // Create an intermediate data structure for assertion const output = dataTeamMembers.map((teamMember) => teamMember.id); - assert.deepEqual(output, ['chris-thoburn', 'krystan-huffMenne']); + assert.deepEqual(output, ['chris-thoburn', 'krystan-huffmenne']); }); test('We sort Learning team members by when they were first added', function (assert) { From 9f9551f33e8a2695c5a72eb402c74d37c62b6d89 Mon Sep 17 00:00:00 2001 From: Ignace Maes Date: Wed, 1 May 2024 08:06:49 +0200 Subject: [PATCH 3/3] test: add alumni --- tests/unit/controllers/teams-test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/controllers/teams-test.js b/tests/unit/controllers/teams-test.js index 5d1906a2..e5647b8b 100644 --- a/tests/unit/controllers/teams-test.js +++ b/tests/unit/controllers/teams-test.js @@ -127,6 +127,7 @@ module('Unit | Controller | teams', function (hooks) { 'chris-krycho', 'dan-freeman', 'bert-de-block', + 'scott-newcomer', ]); }); });