-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest: Prep for v4: V2 Addon conversion #458
Comments
NullVoxPopuli
changed the title
Todos for conversion to native package
Quest: Prep for v4: V2 Addon conversion
Oct 3, 2023
This was referenced Oct 12, 2023
This was referenced Oct 25, 2023
This was referenced Dec 4, 2023
Merged
Merged
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NOTE: the
main
branch will not be releasable during this time, because we need to complete the plan, so that there is minimal/zero disruption to folks' test suites.Here is a preview of what's in the next major:
In order of blockers:
we should keep changes on this branch to the bare minimum, as we don't want to need to sync back to
main
unless we really have to.NOTE that the v3 branch is a snapshot of what this repo looked like before everything is this quest issues started happening
Can happen in any order
Add 4 empty test apps (all boilerplate) #460
move tests to base-tests app, drop support for 3.8, 3.12, 0.x embroider, and ember-classic #463
Add support for ember-concurrency@v3 #465
ComputedProperty
which is different from the built-in types)Move ember-concurrency-specific-tests to the ember-concurrency@v2 test-app #464
Drop support for ember-concurrency@v2 (ember-concurrency is on @v4 now anyway) #500
ember-fetch@v8
main
branch -- already implemented a long time ago viagetGlobal
and storing theWAITERS
onglobalThis
.@ember/test-waiters
to a native packageWAITERS
' keys. (allows deleting code)@ts-ignore
from the test-appsfetch
-- coordinate with Maintenance, V2, modernfetch
, etc ember-cli/ember-fetch#738@ember/test-waiters
is present across all their dependencies (which won't be required for the waiter system to work, but will be required to get improvements across the whole dep graph)add notes for addon authors to utilizewith state held onpeerDependencies
with@ember/test-waiters
(with permissive range, which would be allowed post-globalThis
usage)globalThis
, we don't needpeerDependencies
, we can allow duplicates of test-waiters. Usingdependencies
instead ofpeerDependencies
can help make installation experience smoother for folks, however everyone should end up having@ember/test-waiters
declared in their apps anyway.ember-test-waiters
that re-exports everything from@ember/test-waiters
this is needed because some super old projects import from ember-test-waiters, and if someone is using v4 of test waiters, yet part of their dep graph uses the super old ember-test-waiters, we may want to do this to allow users control over which
@ember/test-waiters
their deep dep ofember-test-waiters
is using.We may also want to "wait and see" if this problem even exists.
ember-test-waiters
as deprecatedhttps://www.npmjs.com/package/ember-test-waiters
The text was updated successfully, but these errors were encountered: