Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #20 : Group rules into few categories by priority #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PauliusMacernis
Copy link
Member

Group rules into few categories by priority, disable rules that contradicts standards or falls into discussable "other" category (these may come back after discussed), change psr2 to psr12 (psr12 includes compatible part of psr2, psr2 is deprecated as of 2019-08-10).

…es that contradicts standards or falls into discussable "other" category (these may come back after discussed), change psr2 to psr12 (psr12 includes compatible part of psr2, psr2 is deprecated as of 2019-08-10).
@jbieliauskas
Copy link
Collaborator

Check out #25 on Closes.

Copy link
Collaborator

@jbieliauskas jbieliauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new lines at the end of files.

@PauliusMacernis
Copy link
Member Author

PauliusMacernis commented Nov 12, 2019

Please add new lines at the end of files.

PSR2:

All PHP files MUST end with a single blank line.

As of 2019-08-10 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative.

PSR12:

This specification extends, expands and replaces PSR-2, ...

All PHP files MUST end with a non-blank line, terminated with a single LF.

Probably needs to be investigated more?

Update:
php-fig/fig-standards#1173

@jbieliauskas
Copy link
Collaborator

You're saying that it's not a php file, so doesn't have to include a LF at the end?

The line feeds are a UNIX thing. A line isn't considered a line if it isn't followed by a LF. Most standard tools require this, for example, wc -l standards/akeneo.yaml yields 13 instead of 14. It's a general practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants