.venv/lib/python3.11/site-packages/websockets/legacy/server.py:1185: DeprecationWarning: remove second argument of ws_handler warnings.warn("remove second argument of ws_handler", DeprecationWarning)

[nmoreaud]

Hello
I have the following deprecation warning with uvicorn==0.31 & websockets==13.0.1.

.venv/lib/python3.11/site-packages/websockets/legacy/server.py:1185: DeprecationWarning: remove second argument of ws_handler
  warnings.warn("remove second argument of ws_handler", DeprecationWarning)

In websockets 13.0 (very recent version), there are breaking changes about async def handler
https://websockets.readthedocs.io/en/stable/project/changelog.html#id6

I think uvicorn still defines the websocket handler with the previous signature:
https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/websockets_impl.py#L227C1-L227C111

[FeodorFitsner]

Second it. That deprecation warning is confusing to the users of our framework.

I can do a PR if that's OK?

[Kludex]

Sure. Please do not drop the minimum websockets version.

[FeodorFitsner]

I can do a PR, but let me first to describe the way I'm going to do a fix to support both <= 10.0 and > 10.0 versions of websockets.

So, the warning is coming from remove_path_argument(ws_handler) method which is used to "strip" the second argument from the handler.

I think in https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/websockets_impl.py we can define two ws_handler methods, for example:

    def ws_handler(self, protocol: WebSocketServerProtocol) -> Any:  # type: ignore[override]
        return self.ws_handler_legacy(protocol, None)

    async def ws_handler_legacy(self, protocol: WebSocketServerProtocol, path: str) -> Any:  # type: ignore[override]
        self.handshake_completed_event.set()
        await self.wait_closed()

Then here we could check if websockets.legacy.server module has remove_path_argument method and then provide ws_handler without a second str argument.

Minimal overhead though it's assumed we "know" there is remove_path_argument method. How does it sound like?

[nmoreaud]

There is also:

.venv/lib/python3.11/site-packages/websockets/exceptions.py:122: DeprecationWarning: ConnectionClosed.code is deprecated; use Protocol.close_code or ConnectionClosed.rcvd.code
  warnings.warn(  # deprecated in 13.1
.venv/lib/python3.11/site-packages/websockets/exceptions.py:133: DeprecationWarning: ConnectionClosed.reason is deprecated; use Protocol.close_reason or ConnectionClosed.rcvd.reason
  warnings.warn(  # deprecated in 13.1

[Kludex]

Where's that used?

[Kludex]

You are not using the latest uvicorn version, are you?

[nmoreaud]

uvicorn==0.31.0

[Kludex]

[nmoreaud]

Ok nice, I'm going to test this version

[Kludex]

But also... Just to clarify... The warning you see on the description of this discussion was left on purpose because I wanted to support old websockets versions, and don't add complexity to the code source.

[nmoreaud]

So, even if I use the latest version of websockets and uvicorn, this warning will still be emitted?
Because for now I still see it:

.venv/lib/python3.11/site-packages/websockets/legacy/server.py:1187: DeprecationWarning: remove second argument of ws_handler
uvicorn==0.32.0
websockets==13.1

[Kludex]

Yes, that's what I'm saying that it was on purpose.

[gumantov]

how can I fix that? I am running in this issue and I was not able to fix it by upgrading websockets, unicorn to the latest versions.

[gumantov]

lib/python3.11/site-packages/websockets/legacy/__init__.py:6: DeprecationWarning: websockets.legacy is deprecated; see https://websockets.readthedocs.io/en/stable/howto/upgrade.html for upgrade instructions
warnings.warn( # deprecated in 14.0`