Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

warn user when uses prerendered pages with revalidate: 0 #22

Open
eneajaho opened this issue Jul 31, 2022 · 8 comments
Open

warn user when uses prerendered pages with revalidate: 0 #22

eneajaho opened this issue Jul 31, 2022 · 8 comments

Comments

@eneajaho
Copy link
Owner

No description provided.

@jdgamble555
Copy link

The logging doesn't seem to be working at all with revalidate: 0 either!

J

@eneajaho
Copy link
Owner Author

Hello @jdgamble555

Can you explain more what do you mean by that?

@jdgamble555
Copy link

Yes. When I set revalidate: 5 I can see the logging in my server console. However, there is no logging when revalidate: 0.

Thanks,

J

@eneajaho
Copy link
Owner Author

Hello @jdgamble555
I just tested this and here's what I get.

Screenshot 2022-09-27 at 5 45 49 PM

Can you provide more info please?
Are you using the default cache handler or the FileSystemCacheHandler?

Thanks.

@jdgamble555
Copy link

Although your server.ts file has a different cache, I haven't seen any instructions on using it. (What are the differences?)

Needless to say, I'm using the default cache.

J

@jdgamble555
Copy link

jdgamble555 commented Sep 27, 2022

Here is my repository, although you can't really test it.

https://github.com/jdgamble555/fireblog.io

J

@eneajaho
Copy link
Owner Author

Hello @jdgamble555 , sorry for late reply, I've been busy with other work.

I'm using the default cache too on that example. Did you manage to solve your issue?
If not, can you provide me a reproduction repo that I can clone and check it?

Thanks.

@jdgamble555
Copy link

I think I got it working. I migrated my old app to a new app and have no problems. I'm not sure what happened. Thanks for your time and work on this.

Would be cool to copy this feature in SvelteKit btw. I imagine if it works in Vite, it could work anywhere.

Thanks,

J

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants