Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening GalyleoRichTextControl causes page to hang #157

Open
rickmcgeer opened this issue Feb 15, 2023 · 1 comment
Open

Opening GalyleoRichTextControl causes page to hang #157

rickmcgeer opened this issue Feb 15, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rickmcgeer
Copy link
Contributor

import { part } from "lively.morphic";
import { GalyleoRichTextControl } from "galyleo-dashboard/studio/controls/text.cp.js";

part(GalyleoRichTextControl).openInWorld() (or opening any containing morph, all the way to Galyleo) causes the world to hang. Commenting out the text controls and font color input submorphs takes care of the problem.
Presumably what's happened is that RichTextControl, which we import from lively.ide/studio/controls/text.cp.js, duplicates this functionality and this is causing a loop.
Tentative solution is to delete the commented out code
Assigning to @merryman for comment and review

@rickmcgeer rickmcgeer added the bug Something isn't working label Feb 15, 2023
@merryman
Copy link
Collaborator

The reason is an infinite loop in the text bounds measuring that is triggered by the number input morphs. I have observed this issue already in the past and believe I have a fix for it lying around somewhere, I just havent pushed it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants