Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart Editor isn't firing up when a new chart is added from the UI #167

Open
rickmcgeer opened this issue Apr 4, 2023 · 1 comment
Open

Chart Editor isn't firing up when a new chart is added from the UI #167

rickmcgeer opened this issue Apr 4, 2023 · 1 comment
Assignees
@rickmcgeer @merryman
Labels
bug Something isn't working review fixed, ready for review

Comments

@rickmcgeer
Copy link
Contributor

And the chart list isn't being updated.
@rickmcgeer rickmcgeer self-assigned this Apr 4, 2023
@rickmcgeer rickmcgeer added the bug Something isn't working label Apr 4, 2023
@rickmcgeer
Copy link
Contributor Author

This was a one-word change
In

$world.execCommand("open browser", {moduleName: "studio/dashboard.cp.js", packageName: "galyleo-dashboard", codeEntity: [{"name":"Dashboard","type":"class-decl"},{"name":"addChart","type":"class-instance-method"}]});

there is a call super.addChart(chartName, chartSpecification, editChartStyle) but super.addChart is async and it wasn't awaiting the return. Changed to await super.addChart(chartName, chartSpecification, editChartStyle)
Assigning to @merryman for review

@rickmcgeer rickmcgeer added the review fixed, ready for review label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickmcgeer rickmcgeer

@merryman merryman

Labels
bug Something isn't working review fixed, ready for review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rickmcgeer @merryman