Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limits with ActiveJob & ActionMailer #28

Open
bwillis opened this issue May 31, 2018 · 0 comments
Open

Rate limits with ActiveJob & ActionMailer #28

bwillis opened this issue May 31, 2018 · 0 comments

Comments

@bwillis
Copy link

bwillis commented May 31, 2018

Both ActiveJob and ActionMailer queue Sidekiq jobs, but they will be wrapped. This causes all of them to use the same rate limit rules. To help with this, the Sidekiq adapter includes in the payload a "wrapped" attribute pointing to the original class (sidekiq/sidekiq#2248). It seems this would be a useful improvement to use the wrapper when it's present.

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwillis