Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wit-bindgen #46

Open
6 tasks
jakehemmerle opened this issue Jan 2, 2024 · 0 comments
Open
6 tasks

Bump wit-bindgen #46

jakehemmerle opened this issue Jan 2, 2024 · 0 comments
Labels
code quality refactor; makes things simpler good first issue Good for newcomers

Comments

@jakehemmerle
Copy link
Contributor

The latest version of cargo-component includes a small wit spec change where semicolons are required after certain statements (eg EOL of package and export declarations). Short term patch fix is to install an older version of cargo-component via cargo install cargo-component --version 0.2.0.

Latest versions of wit-bindgen have removed the macro_export macro parameter. I did not look thoroughly, but it appears that there is no new parameter replacement for it. If we cannot export the generated macro, there may be some refactoring and restructuring that increases the scope here, and a new issue may need to be opened.

TODO:

  • Bump ec-core's wit-bindgen to latest version
  • Fix wit-bindgen related macro issues (eg macro_export error)
  • Fix .wit declarations as the loud compile-time errors describe
  • Confirm an example program can be compiled via cargo component build...
  • Remove the --version 0.2.0 patch-fix from README.md

Bonus:

  • Change ec-core to depend on workspace version of wit-bindgen
@jakehemmerle jakehemmerle added good first issue Good for newcomers code quality refactor; makes things simpler labels Jan 2, 2024
jakehemmerle added a commit that referenced this issue Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality refactor; makes things simpler good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant